Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce6a504d authored by Jens Axboe's avatar Jens Axboe Committed by Treehugger Robot
Browse files

UPSTREAM: io_uring: always grab lock in io_cancel_async_work() 



No upstream commit exists for this patch.

It's not necessarily safe to check the task_list locklessly, remove
this micro optimization and always grab task_lock before deeming it
empty.

Bug: 278721720
Reported-and-tested-by: default avatarLee Jones <lee@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit b0bfceaa)
Signed-off-by: default avatarLee Jones <joneslee@google.com>
Change-Id: I112708bdbe43f0e1c2cad5e73a56d7609c10d339
parent d4fabc5c

fs/io_uring.c

+0 −3
Original line number Diff line number Diff line
@@ -3735,9 +3735,6 @@ static void io_cancel_async_work(struct io_ring_ctx *ctx, 
{

	struct io_kiocb *req;



	if (list_empty(&ctx->task_list))

		return;



	spin_lock_irq(&ctx->task_lock);



	list_for_each_entry(req, &ctx->task_list, task_list) {