Commit ce64cea4 authored May 01, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman May 01, 2019

usb: isp1760-hcd: Fix fall-through annotations



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/usb/isp1760/isp1760-hcd.c: In function ‘collect_qtds’:
drivers/usb/isp1760/isp1760-hcd.c:788:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
      mem_reads8(hcd->regs, qtd->payload_addr,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        qtd->data_buffer,
        ~~~~~~~~~~~~~~~~~
        qtd->actual_length);
        ~~~~~~~~~~~~~~~~~~~
drivers/usb/isp1760/isp1760-hcd.c:792:5: note: here
     case OUT_PID:
     ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comments are modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e823d948

drivers/usb/isp1760/isp1760-hcd.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -788,11 +788,11 @@ static void collect_qtds(struct usb_hcd hcd, struct isp1760_qh qh,
		mem_reads8(hcd->regs, qtd->payload_addr,
		qtd->data_buffer,
		qtd->actual_length);
		/* Fall through (?) */
		/* Fall through */
		case OUT_PID:
		qtd->urb->actual_length +=
		qtd->actual_length;
		/* Fall through ... */
		/* Fall through */
		case SETUP_PID:
		break;
		}