Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd60be49 authored by Roberto Sassu's avatar Roberto Sassu Committed by Martin K. Petersen
Browse files

scsi: lpfc: avoid double free of resource identifiers 



Set variables initialized in lpfc_sli4_alloc_resource_identifiers() to
NULL if an error occurred. Otherwise, lpfc_sli4_driver_resource_unset()
attempts to free the memory again.

Signed-off-by: default avatarRoberto Sassu <rsassu@suse.de>
Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Acked-by: default avatarJames Smart <james.smart@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 98624c4f

drivers/scsi/lpfc/lpfc_sli.c

+7 −0
Original line number Diff line number Diff line
@@ -5954,18 +5954,25 @@ lpfc_sli4_alloc_resource_identifiers(struct lpfc_hba *phba) 














 free_vfi_bmask:















	kfree(phba->sli4_hba.vfi_bmask);













	phba->sli4_hba.vfi_bmask = NULL;















 free_xri_ids:















	kfree(phba->sli4_hba.xri_ids);













	phba->sli4_hba.xri_ids = NULL;















 free_xri_bmask:















	kfree(phba->sli4_hba.xri_bmask);













	phba->sli4_hba.xri_bmask = NULL;















 free_vpi_ids:















	kfree(phba->vpi_ids);













	phba->vpi_ids = NULL;















 free_vpi_bmask:















	kfree(phba->vpi_bmask);













	phba->vpi_bmask = NULL;















 free_rpi_ids:















	kfree(phba->sli4_hba.rpi_ids);













	phba->sli4_hba.rpi_ids = NULL;















 free_rpi_bmask:















	kfree(phba->sli4_hba.rpi_bmask);













	phba->sli4_hba.rpi_bmask = NULL;















 err_exit:















	return rc;















}