Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd24bafe authored by Thadeu Lima de Souza Cascardo's avatar Thadeu Lima de Souza Cascardo Committed by Greg Kroah-Hartman
Browse files

ipmi: bail out if init_srcu_struct fails 



commit 2b5160b12091285c5aca45980f100a9294af7b04 upstream.

In case, init_srcu_struct fails (because of memory allocation failure), we
might proceed with the driver initialization despite srcu_struct not being
entirely initialized.

Fixes: 913a89f0 ("ipmi: Don't initialize anything in the core until something uses it")
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org
Message-Id: <20211217154410.1228673-1-cascardo@canonical.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5525d80d

drivers/char/ipmi/ipmi_msghandler.c

+3 −1
Original line number Diff line number Diff line
@@ -5156,7 +5156,9 @@ static int ipmi_init_msghandler(void) 
	if (initialized)

		goto out;



	init_srcu_struct(&ipmi_interfaces_srcu);

	rv = init_srcu_struct(&ipmi_interfaces_srcu);

	if (rv)

		goto out;



	timer_setup(&ipmi_timer, ipmi_timeout, 0);

	mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);