Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc93a372 authored by Christian Marangi's avatar Christian Marangi Committed by Greg Kroah-Hartman
Browse files

leds: trigger: netdev: Recheck NETDEV_LED_MODE_LINKUP on dev rename 



[ Upstream commit cee4bd16c3195a701be683f7da9e88c6e11acb73 ]

Dev can be renamed also while up for supported device. We currently
wrongly clear the NETDEV_LED_MODE_LINKUP flag on NETDEV_CHANGENAME
event.

Fix this by rechecking if the carrier is ok on NETDEV_CHANGENAME and
correctly set the NETDEV_LED_MODE_LINKUP bit.

Fixes: 5f820ed52371 ("leds: trigger: netdev: fix handling on interface rename")
Cc: stable@vger.kernel.org # v5.5+
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230419210743.3594-2-ansuelsmth@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 939b8b31

drivers/leds/trigger/ledtrig-netdev.c

+3 −0
Original line number Diff line number Diff line
@@ -318,6 +318,9 @@ static int netdev_trig_notify(struct notifier_block *nb, 
	clear_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode);

	switch (evt) {

	case NETDEV_CHANGENAME:

		if (netif_carrier_ok(dev))

			set_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode);

		fallthrough;

	case NETDEV_REGISTER:

		if (trigger_data->net_dev)

			dev_put(trigger_data->net_dev);