Commit cc1affa2 authored Jan 20, 2023 by Joel Stanley Committed by Greg Kroah-Hartman Feb 22, 2023

pinctrl: aspeed: Fix confusing types in return value



[ Upstream commit 287a344a11f1ebd31055cf9b22c88d7005f108d7 ]

The function signature is int, but we return a bool. Instead return a
negative errno as the kerneldoc suggests.

Fixes: 4d3d0e42 ("pinctrl: Add core support for Aspeed SoCs")
Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lore.kernel.org/r/20230119231856.52014-1-joel@jms.id.au


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f209431b

drivers/pinctrl/aspeed/pinctrl-aspeed.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -115,7 +115,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx,
		int ret = 0;

		if (!exprs)
		return true;
		return -EINVAL;

		while (*exprs && !ret) {
		ret = aspeed_sig_expr_disable(ctx, *exprs);