Commit cc0d47b8 authored May 03, 2019 by Wei Yongjun Committed by David S. Miller May 05, 2019

drivers: net: davinci_mdio: fix return value check in davinci_mdio_probe()



In case of error, the function devm_ioremap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 03f66f06 ("net: ethernet: ti: davinci_mdio: use devm_ioremap()")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ca965346

drivers/net/ethernet/ti/davinci_mdio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -398,8 +398,8 @@ static int davinci_mdio_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		data->regs = devm_ioremap(dev, res->start, resource_size(res));
		if (IS_ERR(data->regs))
		return PTR_ERR(data->regs);
		if (!data->regs)
		return -ENOMEM;

		davinci_mdio_init_clk(data);