Commit cbec1626 authored Apr 20, 2020 by Pierre-Louis Bossart Committed by Greg Kroah-Hartman Jun 24, 2020

soundwire: slave: don't init debugfs on device registration error



[ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ]

The error handling flow seems incorrect, there is no reason to try and
add debugfs support if the device registration did not
succeed. Return on error.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.liao@linux.intel.com


Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a45fc524

drivers/soundwire/slave.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -57,6 +57,8 @@ static int sdw_slave_add(struct sdw_bus *bus,
		list_del(&slave->node);
		mutex_unlock(&bus->bus_lock);
		put_device(&slave->dev);

		return ret;
		}
		sdw_slave_debugfs_init(slave);