Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb772b8c authored by Amit Kucheria's avatar Amit Kucheria Committed by Rafael J. Wysocki
Browse files

cpufreq: scpi: Use auto-registration of thermal cooling device 



Use the CPUFREQ_IS_COOLING_DEV flag to allow cpufreq core to
automatically register as a thermal cooling device.

This allows removal of boiler plate code from the driver.

Signed-off-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
Acked-by: default avatarSudeep Holla <sudeep.holla@arm.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 5da7af9a

drivers/cpufreq/scpi-cpufreq.c

+2 −12
Original line number Diff line number Diff line
@@ -22,7 +22,6 @@ 
#include <linux/cpu.h>

#include <linux/cpufreq.h>

#include <linux/cpumask.h>

#include <linux/cpu_cooling.h>

#include <linux/export.h>

#include <linux/module.h>

#include <linux/of_platform.h>
@@ -34,7 +33,6 @@ 
struct scpi_data {

	struct clk *clk;

	struct device *cpu_dev;

	struct thermal_cooling_device *cdev;

};



static struct scpi_ops *scpi_ops;
@@ -186,7 +184,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy) 
{

	struct scpi_data *priv = policy->driver_data;



	cpufreq_cooling_unregister(priv->cdev);

	clk_put(priv->clk);

	dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);

	kfree(priv);
@@ -195,23 +192,16 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy) 
	return 0;

}



static void scpi_cpufreq_ready(struct cpufreq_policy *policy)

{

	struct scpi_data *priv = policy->driver_data;



	priv->cdev = of_cpufreq_cooling_register(policy);

}



static struct cpufreq_driver scpi_cpufreq_driver = {

	.name	= "scpi-cpufreq",

	.flags	= CPUFREQ_STICKY | CPUFREQ_HAVE_GOVERNOR_PER_POLICY |

		  CPUFREQ_NEED_INITIAL_FREQ_CHECK,

		  CPUFREQ_NEED_INITIAL_FREQ_CHECK |

		  CPUFREQ_IS_COOLING_DEV,

	.verify	= cpufreq_generic_frequency_table_verify,

	.attr	= cpufreq_generic_attr,

	.get	= scpi_cpufreq_get_rate,

	.init	= scpi_cpufreq_init,

	.exit	= scpi_cpufreq_exit,

	.ready	= scpi_cpufreq_ready,

	.target_index	= scpi_cpufreq_set_target,

};