Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb1847cc authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: usb: fix warning in mt76u_buf_free 



Fix following static checker warning in mt76u_buf_free:
  drivers/net/wireless/mediatek/mt76/usb.c:372 mt76u_buf_free()
  warn: address of 'urb->sg[i]' is non-NULL

There is no need to check sg page pointer since urb->num_sgs
has been already validated in mt76u_fill_rx_sg

Fixes: cb83585e ("mt76: usb: fix possible memory leak in mt76u_buf_free")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent fc994dbb

drivers/net/wireless/mediatek/mt76/usb.c

+2 −7
Original line number Diff line number Diff line
@@ -364,16 +364,11 @@ int mt76u_buf_alloc(struct mt76_dev *dev, struct mt76u_buf *buf, 
void mt76u_buf_free(struct mt76u_buf *buf)

{

	struct urb *urb = buf->urb;

	struct scatterlist *sg;

	int i;



	for (i = 0; i < urb->num_sgs; i++) {

		sg = &urb->sg[i];

		if (!sg)

			continue;

	for (i = 0; i < urb->num_sgs; i++)

		skb_free_frag(sg_virt(&urb->sg[i]));



		skb_free_frag(sg_virt(sg));

	}

	if (buf->buf)

		skb_free_frag(buf->buf);