Commit caea33da authored Jul 20, 2012 by Stanislav Kinsbursky Committed by Trond Myklebust Jul 30, 2012

SUNRPC: return negative value in case rpcbind client creation error



Without this patch kernel will panic on LockD start, because lockd_up() checks
lockd_up_net() result for negative value.
From my pow it's better to return negative value from rpcbind routines instead
of replacing all such checks like in lockd_up().

Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org [>= 3.0]

parent 89d77c8f

net/sunrpc/rpcb_clnt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -251,7 +251,7 @@ static int rpcb_create_local_unix(struct net *net)
		if (IS_ERR(clnt)) {
		dprintk("RPC: failed to create AF_LOCAL rpcbind "
		"client (errno %ld).\n", PTR_ERR(clnt));
		result = -PTR_ERR(clnt);
		result = PTR_ERR(clnt);
		goto out;
		}

		@@ -298,7 +298,7 @@ static int rpcb_create_local_net(struct net *net)
		if (IS_ERR(clnt)) {
		dprintk("RPC: failed to create local rpcbind "
		"client (errno %ld).\n", PTR_ERR(clnt));
		result = -PTR_ERR(clnt);
		result = PTR_ERR(clnt);
		goto out;
		}