Commit cac1473d authored Jan 14, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Apr 15, 2022

soc: ti: wkup_m3_ipc: Fix IRQ check in wkup_m3_ipc_probe



[ Upstream commit c3d66a164c726cc3b072232d3b6d87575d194084 ]

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: cdd5de50 ("soc: ti: Add wkup_m3_ipc driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
Acked-by: Dave Gerlach <d-gerlach@ti.com>
Link: https://lore.kernel.org/r/20220114062840.16620-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent fb7f2eab

drivers/soc/ti/wkup_m3_ipc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -447,9 +447,9 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
		}

		irq = platform_get_irq(pdev, 0);
		if (!irq) {
		if (irq < 0) {
		dev_err(&pdev->dev, "no irq resource\n");
		return -ENXIO;
		return irq;
		}

		ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,