Commit ca5eda5d authored Jun 27, 2016 by Masahiro Yamada Committed by Rafael J. Wysocki Jun 27, 2016

cpufreq: dt: call of_node_put() before error out



If of_match_node() fails, this init function bails out without
calling of_node_put().

Also change of_node_put(of_root) to of_node_put(np); both of them
hold the same pointer, but it seems better to call of_node_put()
against the node returned by of_find_node_by_path().

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 5ab666e0

drivers/cpufreq/cpufreq-dt-platdev.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -79,15 +79,16 @@ static const struct of_device_id machines[] __initconst = {
		static int __init cpufreq_dt_platdev_init(void)
		{
		struct device_node *np = of_find_node_by_path("/");
		const struct of_device_id *match;

		if (!np)
		return -ENODEV;

		if (!of_match_node(machines, np))
		match = of_match_node(machines, np);
		of_node_put(np);
		if (!match)
		return -ENODEV;

		of_node_put(of_root);

		return PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt", -1,
		NULL, 0));
		}