Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9f92600 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Martin K. Petersen
Browse files

scsi: libsas: Disable asynchronous aborts for SATA devices 



Handling CD-ROM devices from libsas is decidedly odd, as libata relies
on SCSI EH to be started to figure out that no medium is present.  So we
cannot do asynchronous aborts for SATA devices.

Fixes: 90965761 ("scsi: libsas: allow async aborts")
Cc: <stable@vger.kernel.org> # 4.12+
Signed-off-by: default avatarHannes Reinecke <hare@suse.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Tested-by: default avatarYves-Alexis Perez <corsac@debian.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d1b8b239

drivers/scsi/libsas/sas_scsi_host.c

+15 −2
Original line number Diff line number Diff line
@@ -486,15 +486,28 @@ static int sas_queue_reset(struct domain_device *dev, int reset_type, 


int sas_eh_abort_handler(struct scsi_cmnd *cmd)

{

	int res;

	int res = TMF_RESP_FUNC_FAILED;

	struct sas_task *task = TO_SAS_TASK(cmd);

	struct Scsi_Host *host = cmd->device->host;

	struct domain_device *dev = cmd_to_domain_dev(cmd);

	struct sas_internal *i = to_sas_internal(host->transportt);

	unsigned long flags;



	if (!i->dft->lldd_abort_task)

		return FAILED;



	spin_lock_irqsave(host->host_lock, flags);

	/* We cannot do async aborts for SATA devices */

	if (dev_is_sata(dev) && !host->host_eh_scheduled) {

		spin_unlock_irqrestore(host->host_lock, flags);

		return FAILED;

	}

	spin_unlock_irqrestore(host->host_lock, flags);



	if (task)

		res = i->dft->lldd_abort_task(task);

	else

		SAS_DPRINTK("no task to abort\n");

	if (res == TMF_RESP_FUNC_SUCC || res == TMF_RESP_FUNC_COMPLETE)

		return SUCCESS;