Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9c96e30 authored by Marc Zyngier's avatar Marc Zyngier
Browse files

irqchip/gic-v3-its: Fix LPI release for Multi-MSI devices 



When allocating a range of LPIs for a Multi-MSI capable device,
this allocation extended to the closest power of 2.

But on the release path, the interrupts are released one by
one. This results in not releasing the "extra" range, leaking
the its_device. Trying to reprobe the device will then fail.

Fix it by releasing the LPIs the same way we allocate them.

Fixes: 8208d170 ("irqchip/gic-v3-its: Align PCI Multi-MSI allocation on their size")
Reported-by: default avatarJiaxing Luo <luojiaxing@huawei.com>
Tested-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/f5e948aa-e32f-3f74-ae30-31fee06c2a74@huawei.com
parent e89327f6

drivers/irqchip/irq-gic-v3-its.c

+4 −5
Original line number Diff line number Diff line
@@ -2641,14 +2641,13 @@ static void its_irq_domain_free(struct irq_domain *domain, unsigned int virq, 
	struct its_node *its = its_dev->its;

	int i;



	bitmap_release_region(its_dev->event_map.lpi_map,

			      its_get_event_id(irq_domain_get_irq_data(domain, virq)),

			      get_count_order(nr_irqs));



	for (i = 0; i < nr_irqs; i++) {

		struct irq_data *data = irq_domain_get_irq_data(domain,

								virq + i);

		u32 event = its_get_event_id(data);



		/* Mark interrupt index as unused */

		clear_bit(event, its_dev->event_map.lpi_map);



		/* Nuke the entry in the domain */

		irq_domain_reset_irq_data(data);

	}