Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9adb431 authored by Magnus Damm's avatar Magnus Damm Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (11731): buf-dma-contig: remove sync operation 



Remove the videobuf-dma-contig sync operation. Sync is only needed
for noncoherent buffers, and since videobuf-dma-contig is built on
coherent memory allocators the memory is by definition always in sync.

Reported-by: default avatarMatthieu CASTET <matthieu.castet@parrot.com>
Signed-off-by: default avatarMagnus Damm <damm@igel.co.jp>
Reviewed-by: default avatarPaul Mundt <lethal@linux-sh.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 6e9c1a2a

drivers/media/video/videobuf-dma-contig.c

+0 −14
Original line number Diff line number Diff line
@@ -182,19 +182,6 @@ static int __videobuf_iolock(struct videobuf_queue *q, 
	return 0;

}



static int __videobuf_sync(struct videobuf_queue *q,

			   struct videobuf_buffer *buf)

{

	struct videobuf_dma_contig_memory *mem = buf->priv;



	BUG_ON(!mem);

	MAGIC_CHECK(mem->magic, MAGIC_DC_MEM);



	dma_sync_single_for_cpu(q->dev, mem->dma_handle, mem->size,

				DMA_FROM_DEVICE);

	return 0;

}



static int __videobuf_mmap_free(struct videobuf_queue *q)

{

	unsigned int i;
@@ -356,7 +343,6 @@ static struct videobuf_qtype_ops qops = { 


	.alloc        = __videobuf_alloc,

	.iolock       = __videobuf_iolock,

	.sync         = __videobuf_sync,

	.mmap_free    = __videobuf_mmap_free,

	.mmap_mapper  = __videobuf_mmap_mapper,

	.video_copy_to_user = __videobuf_copy_to_user,