Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c99776cc authored by Aditya Pakki's avatar Aditya Pakki Committed by Takashi Iwai
Browse files

ALSA: ice1712: fix a missing check of snd_i2c_sendbytes 



snd_i2c_sendbytes could fail. The fix checks its return value: if it
fails, issues an error message and returns with its error code.

Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0f25e000

sound/pci/ice1712/ews.c

+6 −1
Original line number Diff line number Diff line
@@ -826,7 +826,12 @@ static int snd_ice1712_6fire_read_pca(struct snd_ice1712 *ice, unsigned char reg 


	snd_i2c_lock(ice->i2c);

	byte = reg;

	snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1);

	if (snd_i2c_sendbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1)) {

		snd_i2c_unlock(ice->i2c);

		dev_err(ice->card->dev, "cannot send pca\n");

		return -EIO;

	}



	byte = 0;

	if (snd_i2c_readbytes(spec->i2cdevs[EWS_I2C_6FIRE], &byte, 1) != 1) {

		snd_i2c_unlock(ice->i2c);