Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c969c6e7 authored by Huang Zijiang's avatar Huang Zijiang Committed by David S. Miller
Browse files

net: hns: Fix object reference leaks in hns_dsaf_roce_reset() 



The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.

Signed-off-by: default avatarHuang Zijiang <huang.zijiang@zte.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c2ade81

drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

+2 −0
Original line number Diff line number Diff line
@@ -3081,6 +3081,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) 
	dsaf_dev = dev_get_drvdata(&pdev->dev);

	if (!dsaf_dev) {

		dev_err(&pdev->dev, "dsaf_dev is NULL\n");

		put_device(&pdev->dev);

		return -ENODEV;

	}
@@ -3088,6 +3089,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) 
	if (AE_IS_VER1(dsaf_dev->dsaf_ver)) {

		dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n",

			dsaf_dev->ae_dev.name);

		put_device(&pdev->dev);

		return -ENODEV;

	}