Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c967e1df authored by Aya Mahfouz's avatar Aya Mahfouz Committed by Martin Schwidefsky
Browse files

s390/hmcdrv: constify hmcdrv_ftp_ops structs 



Constifies hmcdrv_ftp_ops structures in s390's char
driver since they are not modified after their
initialization.

Detected and found using Coccinelle.

Suggested-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 8cb708f3

drivers/s390/char/hmcdrv_ftp.c

+3 −3
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ struct hmcdrv_ftp_ops { 
static enum hmcdrv_ftp_cmdid hmcdrv_ftp_cmd_getid(const char *cmd, int len);

static int hmcdrv_ftp_parse(char *cmd, struct hmcdrv_ftp_cmdspec *ftp);



static struct hmcdrv_ftp_ops *hmcdrv_ftp_funcs; /* current operations */

static const struct hmcdrv_ftp_ops *hmcdrv_ftp_funcs; /* current operations */

static DEFINE_MUTEX(hmcdrv_ftp_mutex); /* mutex for hmcdrv_ftp_funcs */

static unsigned hmcdrv_ftp_refcnt; /* start/shutdown reference counter */
@@ -290,13 +290,13 @@ ssize_t hmcdrv_ftp_cmd(char __kernel *cmd, loff_t offset, 
 */

int hmcdrv_ftp_startup(void)

{

	static struct hmcdrv_ftp_ops hmcdrv_ftp_zvm = {

	static const struct hmcdrv_ftp_ops hmcdrv_ftp_zvm = {

		.startup = diag_ftp_startup,

		.shutdown = diag_ftp_shutdown,

		.transfer = diag_ftp_cmd

	};



	static struct hmcdrv_ftp_ops hmcdrv_ftp_lpar = {

	static const struct hmcdrv_ftp_ops hmcdrv_ftp_lpar = {

		.startup = sclp_ftp_startup,

		.shutdown = sclp_ftp_shutdown,

		.transfer = sclp_ftp_cmd