Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9624514 authored by Jason Gunthorpe's avatar Jason Gunthorpe
Browse files

mm/mmu_notifiers: remove unregister_no_release 

mmu_notifier_unregister_no_release() and mmu_notifier_call_srcu() no
longer have any users, they have all been converted to use
mmu_notifier_put().

So delete this difficult to use interface.

Link: https://lore.kernel.org/r/20190806231548.25242-12-jgg@ziepe.ca


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarRalph Campbell <rcampbell@nvidia.com>
Tested-by: default avatarRalph Campbell <rcampbell@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 47f725ee

include/linux/mmu_notifier.h

+0 −5
Original line number Diff line number Diff line
@@ -271,8 +271,6 @@ extern int __mmu_notifier_register(struct mmu_notifier *mn, 
				   struct mm_struct *mm);

extern void mmu_notifier_unregister(struct mmu_notifier *mn,

				    struct mm_struct *mm);

extern void mmu_notifier_unregister_no_release(struct mmu_notifier *mn,

					       struct mm_struct *mm);

extern void __mmu_notifier_mm_destroy(struct mm_struct *mm);

extern void __mmu_notifier_release(struct mm_struct *mm);

extern int __mmu_notifier_clear_flush_young(struct mm_struct *mm,
@@ -513,9 +511,6 @@ static inline void mmu_notifier_range_init(struct mmu_notifier_range *range, 
	set_pte_at(___mm, ___address, __ptep, ___pte);			\

})



extern void mmu_notifier_call_srcu(struct rcu_head *rcu,

				   void (*func)(struct rcu_head *rcu));



#else /* CONFIG_MMU_NOTIFIER */



struct mmu_notifier_range {

mm/mmu_notifier.c

+0 −31
Original line number Diff line number Diff line
@@ -21,18 +21,6 @@ 
/* global SRCU for all MMs */

DEFINE_STATIC_SRCU(srcu);



/*

 * This function allows mmu_notifier::release callback to delay a call to

 * a function that will free appropriate resources. The function must be

 * quick and must not block.

 */

void mmu_notifier_call_srcu(struct rcu_head *rcu,

			    void (*func)(struct rcu_head *rcu))

{

	call_srcu(&srcu, rcu, func);

}

EXPORT_SYMBOL_GPL(mmu_notifier_call_srcu);



/*

 * This function can't run concurrently against mmu_notifier_register

 * because mm->mm_users > 0 during mmu_notifier_register and exit_mmap
@@ -455,25 +443,6 @@ void mmu_notifier_unregister(struct mmu_notifier *mn, struct mm_struct *mm) 
}

EXPORT_SYMBOL_GPL(mmu_notifier_unregister);



/*

 * Same as mmu_notifier_unregister but no callback and no srcu synchronization.

 */

void mmu_notifier_unregister_no_release(struct mmu_notifier *mn,

					struct mm_struct *mm)

{

	spin_lock(&mm->mmu_notifier_mm->lock);

	/*

	 * Can not use list_del_rcu() since __mmu_notifier_release

	 * can delete it before we hold the lock.

	 */

	hlist_del_init_rcu(&mn->hlist);

	spin_unlock(&mm->mmu_notifier_mm->lock);



	BUG_ON(atomic_read(&mm->mm_count) <= 0);

	mmdrop(mm);

}

EXPORT_SYMBOL_GPL(mmu_notifier_unregister_no_release);



static void mmu_notifier_free_rcu(struct rcu_head *rcu)

{

	struct mmu_notifier *mn = container_of(rcu, struct mmu_notifier, rcu);