Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c961cb3b authored by Rob Herring's avatar Rob Herring
Browse files

of: Fix cpu node iterator to not ignore disabled cpu nodes 



In most cases, nodes with 'status = "disabled";' are treated as if the
node is not present though it is a common bug to forget to check that.
However, cpu nodes are different in that "disabled" simply means offline
and the OS can bring the CPU core online. Commit f1f207e4 ("of: Add
cpu node iterator for_each_of_cpu_node()") followed the common behavior
of ignoring disabled cpu nodes. This breaks some powerpc systems (at
least NXP P50XX/e5500). Fix this by dropping the status check.

Fixes: 651d44f9 ("of: use for_each_of_cpu_node iterator")
Fixes: f1f207e4 ("of: Add cpu node iterator for_each_of_cpu_node()")
Reported-by: default avatarChristian Zigotzky <chzigotzky@xenosoft.de>
Tested-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 204c881e

drivers/of/base.c

+0 −2
Original line number Diff line number Diff line
@@ -776,8 +776,6 @@ struct device_node *of_get_next_cpu_node(struct device_node *prev) 
		if (!(of_node_name_eq(next, "cpu") ||

		      (next->type && !of_node_cmp(next->type, "cpu"))))

			continue;

		if (!__of_device_is_available(next))

			continue;

		if (of_node_get(next))

			break;

	}