Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c92737ce authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: fix deadlock in add_link failure



mkdir                        sync_dirty_inode
 - init_inode_metadata
   - lock_page(node)
   - make_empty_dir
                             - filemap_fdatawrite()
                              - do_writepages
                              - lock_page(data)
                              - write_page(data)
                               - lock_page(node)
   - f2fs_init_acl
    - error
   - truncate_inode_pages
    - lock_page(data)

So, we don't need to truncate data pages in this error case, which will
be done by f2fs_evict_inode.

Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 36abef4e
Loading
Loading
Loading
Loading
+0 −3
Original line number Diff line number Diff line
@@ -450,9 +450,6 @@ struct page *init_inode_metadata(struct inode *inode, struct inode *dir,
	return page;

put_error:
	/* truncate empty dir pages */
	truncate_inode_pages(&inode->i_data, 0);

	clear_nlink(inode);
	update_inode(inode, page);
	f2fs_put_page(page, 1);