Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8fb7b82 authored by Sunil Challa's avatar Sunil Challa Committed by David S. Miller
Browse files

bnxt_en: wildcard smac while creating tunnel decap filter 



While creating a decap filter the tunnel smac need not (and must not) be
specified as we cannot ascertain the neighbor in the recv path. 'ttl'
match is also not needed for the decap filter and must be wild-carded.

Fixes: f484f678 ("bnxt_en: add hwrm FW cmds for cfa_encap_record and decap_filter")
Signed-off-by: default avatarSunil Challa <sunilkumar.challa@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a7f3f939

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

+2 −5
Original line number Diff line number Diff line
@@ -532,10 +532,8 @@ static int hwrm_cfa_decap_filter_alloc(struct bnxt *bp, 
	}



	if (flow->flags & BNXT_TC_FLOW_FLAGS_TUNL_ETH_ADDRS) {

		enables |= CFA_DECAP_FILTER_ALLOC_REQ_ENABLES_DST_MACADDR |

			   CFA_DECAP_FILTER_ALLOC_REQ_ENABLES_SRC_MACADDR;

		enables |= CFA_DECAP_FILTER_ALLOC_REQ_ENABLES_DST_MACADDR;

		ether_addr_copy(req.dst_macaddr, l2_info->dmac);

		ether_addr_copy(req.src_macaddr, l2_info->smac);

	}

	if (l2_info->num_vlans) {

		enables |= CFA_DECAP_FILTER_ALLOC_REQ_ENABLES_T_IVLAN_VID;
@@ -1012,10 +1010,9 @@ static int bnxt_tc_get_decap_handle(struct bnxt *bp, struct bnxt_tc_flow *flow, 
	if (rc)

		goto put_decap;



	decap_key->ttl = tun_key.ttl;

	decap_l2_info = &decap_node->l2_info;

	/* decap smac is wildcarded */

	ether_addr_copy(decap_l2_info->dmac, l2_info.smac);

	ether_addr_copy(decap_l2_info->smac, l2_info.dmac);

	if (l2_info.num_vlans) {

		decap_l2_info->num_vlans = l2_info.num_vlans;

		decap_l2_info->inner_vlan_tpid = l2_info.inner_vlan_tpid;