Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c85aa326 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

staging: kpc2000: double unlock in error handling in kpc_dma_transfer() 



The goto err_descr_too_many; calls unlock_engine() so this unlocks
twice.

Fixes: 7df95299 ("staging: kpc2000: Add DMA driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d4c596eb

drivers/staging/kpc2000/kpc_dma/fileops.c

+0 −2
Original line number Diff line number Diff line
@@ -116,13 +116,11 @@ int kpc_dma_transfer(struct dev_private_data *priv, struct kiocb *kcb, unsigned 
	if (desc_needed >= ldev->desc_pool_cnt){

		dev_warn(&priv->ldev->pldev->dev, "    mapped_entry_count = %d    num_descrs_needed = %d    num_descrs_avail = %d    TOO MANY to ever complete!\n", acd->mapped_entry_count, desc_needed, num_descrs_avail);

		rv = -EAGAIN;

		unlock_engine(ldev);

		goto err_descr_too_many;

	}

	if (desc_needed > num_descrs_avail){

		dev_warn(&priv->ldev->pldev->dev, "    mapped_entry_count = %d    num_descrs_needed = %d    num_descrs_avail = %d    Too many to complete right now.\n", acd->mapped_entry_count, desc_needed, num_descrs_avail);

		rv = -EMSGSIZE;

		unlock_engine(ldev);

		goto err_descr_too_many;

	}