Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c84284e5 authored by Corentin Labbe's avatar Corentin Labbe Committed by Linus Walleij
Browse files

pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank 



This patch fix the following build warning:
drivers/pinctrl/bcm/pinctrl-bcm2835.c:376:15: warning: variable 'type' set but not used [-Wunused-but-set-variable]

Furthermore, it is unused for a long time, at least since commit 85ae9e51 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
where a "FIXME no clue why the code looks up the type here" was added.
A year after, nobody answeered this question, so its time to remove it.

Signed-off-by: default avatarCorentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 2bd6bf03

drivers/pinctrl/bcm/pinctrl-bcm2835.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -373,16 +373,12 @@ static void bcm2835_gpio_irq_handle_bank(struct bcm2835_pinctrl *pc, 
	unsigned long events;

	unsigned long events;

	unsigned offset;

	unsigned offset;

	unsigned gpio;

	unsigned gpio;

	unsigned int type;





	events = bcm2835_gpio_rd(pc, GPEDS0 + bank * 4);

	events = bcm2835_gpio_rd(pc, GPEDS0 + bank * 4);

	events &= mask;

	events &= mask;

	events &= pc->enabled_irq_map[bank];

	events &= pc->enabled_irq_map[bank];

	for_each_set_bit(offset, &events, 32) {

	for_each_set_bit(offset, &events, 32) {

		gpio = (32 * bank) + offset;

		gpio = (32 * bank) + offset;

		/* FIXME: no clue why the code looks up the type here */

		type = pc->irq_type[gpio];



		generic_handle_irq(irq_linear_revmap(pc->gpio_chip.irqdomain,

		generic_handle_irq(irq_linear_revmap(pc->gpio_chip.irqdomain,

						     gpio));

						     gpio));

	}

	}