Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8302367 authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf hists browser: Add ui.show-headers config file option 



Adding ui.show-headers config file option to define if the histogram
entries headers will start visible or not.

Currently columns headers are displayed by default, following
lines in ~/.perfconfig file will disable that:

  [ui]
        show-headers = false

Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1403886418-5556-4-git-send-email-jolsa@kernel.org


[ renamed symbol_conf.show_headers to .show_hist_headers ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 81a888fe

tools/perf/ui/browsers/hists.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1284,7 +1284,7 @@ static struct hist_browser *hist_browser__new(struct hists *hists) 
		browser->b.refresh_dimensions = hist_browser__refresh_dimensions;

		browser->b.refresh_dimensions = hist_browser__refresh_dimensions;

		browser->b.seek = ui_browser__hists_seek;

		browser->b.seek = ui_browser__hists_seek;

		browser->b.use_navkeypressed = true;

		browser->b.use_navkeypressed = true;

		browser->show_headers = true;

		browser->show_headers = symbol_conf.show_hist_headers;

	}

	}





	return browser;

	return browser;

tools/perf/util/config.c

+13 −0
Original line number Original line Diff line number Diff line
@@ -350,6 +350,16 @@ static int perf_default_core_config(const char *var __maybe_unused, 
	return 0;

	return 0;

}

}





static int perf_ui_config(const char *var, const char *value)

{

	/* Add other config variables here. */

	if (!strcmp(var, "ui.show-headers")) {

		symbol_conf.show_hist_headers = perf_config_bool(var, value);

		return 0;

	}

	return 0;

}



int perf_default_config(const char *var, const char *value,

int perf_default_config(const char *var, const char *value,

			void *dummy __maybe_unused)

			void *dummy __maybe_unused)

{

{
@@ -359,6 +369,9 @@ int perf_default_config(const char *var, const char *value, 
	if (!prefixcmp(var, "hist."))

	if (!prefixcmp(var, "hist."))

		return perf_hist_config(var, value);

		return perf_hist_config(var, value);





	if (!prefixcmp(var, "ui."))

		return perf_ui_config(var, value);



	/* Add other config variables here. */

	/* Add other config variables here. */

	return 0;

	return 0;

}

}

tools/perf/util/symbol.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -34,6 +34,7 @@ struct symbol_conf symbol_conf = { 
	.annotate_src		= true,

	.annotate_src		= true,

	.demangle		= true,

	.demangle		= true,

	.cumulate_callchain	= true,

	.cumulate_callchain	= true,

	.show_hist_headers	= true,

	.symfs			= "",

	.symfs			= "",

};

};

tools/perf/util/symbol.h

+2 −1
Original line number Original line Diff line number Diff line
@@ -118,7 +118,8 @@ struct symbol_conf { 
			annotate_src,

			annotate_src,

			event_group,

			event_group,

			demangle,

			demangle,

			filter_relative;

			filter_relative,

			show_hist_headers;

	const char	*vmlinux_name,

	const char	*vmlinux_name,

			*kallsyms_name,

			*kallsyms_name,

			*source_prefix,

			*source_prefix,