Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c802d759 authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller
Browse files

netrom: fix invalid use of sizeof in nr_recvmsg() 



sizeof() when applied to a pointer typed expression gives the size of the
pointer, not that of the pointed data.
Introduced by commit 3ce5ef(netrom: fix info leak via msg_name in nr_recvmsg)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 65d8013c

net/netrom/af_netrom.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1173,7 +1173,7 @@ static int nr_recvmsg(struct kiocb *iocb, struct socket *sock, 
	}

	}





	if (sax != NULL) {

	if (sax != NULL) {

		memset(sax, 0, sizeof(sax));

		memset(sax, 0, sizeof(*sax));

		sax->sax25_family = AF_NETROM;

		sax->sax25_family = AF_NETROM;

		skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call,

		skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call,

			      AX25_ADDR_LEN);

			      AX25_ADDR_LEN);