Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c8004600 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

qed: Add a missing error code 



We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails.  The
current code returns success.

Fixes: 4ed1eea8 ("qed: Revise MFW command locking")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarTomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2c099ccb

drivers/net/ethernet/qlogic/qed/qed_mcp.c

+3 −1
Original line number Diff line number Diff line
@@ -455,8 +455,10 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn, 
	qed_mcp_reread_offsets(p_hwfn, p_ptt);

	seq_num = ++p_hwfn->mcp_info->drv_mb_seq;

	p_cmd_elem = qed_mcp_cmd_add_elem(p_hwfn, p_mb_params, seq_num);

	if (!p_cmd_elem)

	if (!p_cmd_elem) {

		rc = -ENOMEM;

		goto err;

	}



	__qed_mcp_cmd_and_union(p_hwfn, p_ptt, p_mb_params, seq_num);

	spin_unlock_bh(&p_hwfn->mcp_info->cmd_lock);