Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7d5f21e authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Rafael J. Wysocki
Browse files

ACPI: event: replace strcpy() by strscpy() 



The strcpy() function is being deprecated. Replace it by the safer
strscpy() and fix the following Coverity warnings:

"You might overrun the 15-character fixed-size string event->bus_id
by copying bus_id without checking the length."

"You might overrun the 20-character fixed-size string event->device_class
by copying device_class without checking the length."

Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 603fadf3

drivers/acpi/event.c

+2 −2
Original line number Diff line number Diff line
@@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class, 
	event = nla_data(attr);

	memset(event, 0, sizeof(struct acpi_genl_event));



	strcpy(event->device_class, device_class);

	strcpy(event->bus_id, bus_id);

	strscpy(event->device_class, device_class, sizeof(event->device_class));

	strscpy(event->bus_id, bus_id, sizeof(event->bus_id));

	event->type = type;

	event->data = data;