Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7d42f37 authored by Joseph Wright's avatar Joseph Wright Committed by Greg Kroah-Hartman
Browse files

Staging: pi433: check error after kthread_run() 



Error should be checked with IS_ERR after calling kthread_run()
instead of comparing the returned pointer to an int.

Found by sparse warning:

incompatible types for operation (<)
    left side has type struct task_struct *tx_task_struct
    right side has type int

Signed-off-by: default avatarJoseph Wright <rjosephwright@gmail.com>
Reviewed-by: default avatarMarcus Wolf <linux@wolf-entwicklungen.de>
Tested-by: default avatarMarcus Wolf <linux@wolf-entwicklungen.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7de77a39

drivers/staging/pi433/pi433_if.c

+1 −1
Original line number Diff line number Diff line
@@ -1152,7 +1152,7 @@ static int pi433_probe(struct spi_device *spi) 
	device->tx_task_struct = kthread_run(pi433_tx_thread,

					     device,

					     "pi433_tx_task");

	if (device->tx_task_struct < 0)

	if (IS_ERR(device->tx_task_struct))

	{

		dev_dbg(device->dev, "start of send thread failed");

		goto send_thread_failed;