Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7a8209f authored May 10, 2010 by Tejun Heo Committed by Jeff Garzik May 14, 2010

libata-sff: kill unused prototype and make ata_dev_select() static



ata_irq_on() was renamed to ata_sff_irq_on() and exported a while ago
but prototype for the original function lingered in
drivers/ata/libata.h.  Kill it.  Also, ata_dev_select() is only used
inside drivers/ata/libata-sff.c.  Make it static.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 2a7adff0

drivers/ata/libata-sff.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -511,7 +511,7 @@ EXPORT_SYMBOL_GPL(ata_sff_dev_select);
	* LOCKING:		* LOCKING:
	* caller.		* caller.
	*/		*/
	void ata_dev_select(struct ata_port *ap, unsigned int device,		static void ata_dev_select(struct ata_port *ap, unsigned int device,
	unsigned int wait, unsigned int can_sleep)		unsigned int wait, unsigned int can_sleep)
	{		{
	if (ata_msg_probe(ap))		if (ata_msg_probe(ap))

drivers/ata/libata.h

+0 −3

Original line number	Original line	Diff line number	Diff line
	@@ -202,9 +202,6 @@ static inline int sata_pmp_attach(struct ata_device *dev)

	/* libata-sff.c */		/* libata-sff.c */
	#ifdef CONFIG_ATA_SFF		#ifdef CONFIG_ATA_SFF
	extern void ata_dev_select(struct ata_port *ap, unsigned int device,
	unsigned int wait, unsigned int can_sleep);
	extern u8 ata_irq_on(struct ata_port *ap);
	extern void ata_pio_task(struct work_struct *work);		extern void ata_pio_task(struct work_struct *work);
	#endif /* CONFIG_ATA_SFF */		#endif /* CONFIG_ATA_SFF */