Commit c78bb844 authored Nov 24, 2006 by Krishna Kumar Committed by Roland Dreier Nov 29, 2006

RDMA/addr: Fix some cancellation problems in process_req()



Fix following problems in process_req() relating to cancellation:

- Function is wrongly doing another addr_remote() when cancelled,
  which is not required.
- Make failure reporting immediate by using time_after_eq().
- On cancellation, -ETIMEDOUT was returned to the callback routine
  instead of the more appropriate -ECANCELLED (users getting notified
  may want to print/return this status, eg ucma_event_handler).

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent c9edea29

drivers/infiniband/core/addr.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -225,17 +225,16 @@ static void process_req(void *data)

		mutex_lock(&lock);
		list_for_each_entry_safe(req, temp_req, &req_list, list) {
		if (req->status) {
		if (req->status == -ENODATA) {
		src_in = (struct sockaddr_in *) &req->src_addr;
		dst_in = (struct sockaddr_in *) &req->dst_addr;
		req->status = addr_resolve_remote(src_in, dst_in,
		req->addr);
		}
		if (req->status && time_after(jiffies, req->timeout))
		if (req->status && time_after_eq(jiffies, req->timeout))
		req->status = -ETIMEDOUT;
		else if (req->status == -ENODATA)
		continue;

		}
		list_del(&req->list);
		list_add_tail(&req->list, &done_list);
		}