Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c71f4e63 authored by Abhishek Singh's avatar Abhishek Singh Committed by Madan Koyyalamudi
Browse files

qcacmn: Do not drop the beacon in case of RSN len is less than 2 

For security cert TC, RSNIE length can be 1 but if the beacon is
dropped, old entry will remain in scan cache and cause cert TC
failure as connection with old entry with valid RSN IE will pass.

So instead of dropping the frame, do not store the RSN pointer so
that old entry is overwritten.

Change-Id: I2fe4d2dd2352be6850f7a18a2ec829733ded7ee8
CRs-Fixed: 2944120
parent 472935c0

umac/scan/dispatcher/src/wlan_scan_utils_api.c

+10 −3
Original line number Diff line number Diff line
@@ -1035,8 +1035,15 @@ util_scan_populate_bcn_ie_list(struct wlan_objmgr_pdev *pdev, 
				(uint8_t *)&(((struct htcap_ie *)ie)->ie);

			break;

		case WLAN_ELEMID_RSN:

			if (ie->ie_len < WLAN_RSN_IE_MIN_LEN)

				goto err;

			/*

			 * For security cert TC, RSNIE length can be 1 but if

			 * beacon is dropped, old entry will remain in scan

			 * cache and cause cert TC failure as connection with

			 * old entry with valid RSN IE will pass.

			 * So instead of dropping the frame, do not store the

			 * RSN pointer so that old entry is overwritten.

			 */

			if (ie->ie_len >= WLAN_RSN_IE_MIN_LEN)

				scan_params->ie_list.rsn = (uint8_t *)ie;

			break;

		case WLAN_ELEMID_XRATES: