Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6e23d83 authored by Jakob Normark's avatar Jakob Normark Committed by James Bottomley
Browse files

[SCSI] bfa: Fixes for 0-terminated strncpy and possible null pointer dereference 



This patch fixes two cppcheck errors in drivers/scsi/bfa/bfad_im.c

[jejb: correct strlcpy fix]
Signed-off-by: default avatarJakob Normark <jakobnormark@gmail.com>
Acked-by: default avatarVijay Mohan Guvva <vmohan@brocade.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 7525be54

drivers/scsi/bfa/bfad_im.c

+6 −4
Original line number Diff line number Diff line
@@ -944,13 +944,15 @@ static int 
bfad_im_slave_alloc(struct scsi_device *sdev)

{

	struct fc_rport *rport = starget_to_rport(scsi_target(sdev));

	struct bfad_itnim_data_s *itnim_data =

				(struct bfad_itnim_data_s *) rport->dd_data;

	struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;

	struct bfad_itnim_data_s *itnim_data;

	struct bfa_s *bfa;



	if (!rport || fc_remote_port_chkready(rport))

		return -ENXIO;



	itnim_data = (struct bfad_itnim_data_s *) rport->dd_data;

	bfa = itnim_data->itnim->bfa_itnim->bfa;



	if (bfa_get_lun_mask_status(bfa) == BFA_LUNMASK_ENABLED) {

		/*

		 * We should not mask LUN 0 - since this will translate
@@ -1035,7 +1037,7 @@ bfad_fc_host_init(struct bfad_im_port_s *im_port) 
	/* For fibre channel services type 0x20 */

	fc_host_supported_fc4s(host)[7] = 1;



	strncpy(symname, bfad->bfa_fcs.fabric.bport.port_cfg.sym_name.symname,

	strlcpy(symname, bfad->bfa_fcs.fabric.bport.port_cfg.sym_name.symname,

		BFA_SYMNAME_MAXLEN);

	sprintf(fc_host_symbolic_name(host), "%s", symname);