Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6cc75fe authored by Axel Lin's avatar Axel Lin Committed by Linus Walleij
Browse files

gpio: xgene-sb: Use irq_domain_free_irqs_common() 



Current code calls irq_domain_alloc_irqs_parent() in .alloc,
so it should call irq_domain_free_irqs_parent() accordingly in .free.
Fix it by switching to use irq_domain_free_irqs_common() instead.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 63cc787e

drivers/gpio/gpio-xgene-sb.c

+1 −14
Original line number Diff line number Diff line
@@ -216,23 +216,10 @@ static int xgene_gpio_sb_domain_alloc(struct irq_domain *domain, 
			&parent_fwspec);

}



static void xgene_gpio_sb_domain_free(struct irq_domain *domain,

		unsigned int virq,

		unsigned int nr_irqs)

{

	struct irq_data *d;

	unsigned int i;



	for (i = 0; i < nr_irqs; i++) {

		d = irq_domain_get_irq_data(domain, virq + i);

		irq_domain_reset_irq_data(d);

	}

}



static const struct irq_domain_ops xgene_gpio_sb_domain_ops = {

	.translate      = xgene_gpio_sb_domain_translate,

	.alloc          = xgene_gpio_sb_domain_alloc,

	.free           = xgene_gpio_sb_domain_free,

	.free           = irq_domain_free_irqs_common,

	.activate	= xgene_gpio_sb_domain_activate,

	.deactivate	= xgene_gpio_sb_domain_deactivate,

};