Commit c679f6a2 authored Mar 30, 2018 by Wei Yongjun Committed by David S. Miller Mar 31, 2018

net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()



There is no need for explicit calls of devm_kfree(), as the allocated
memory will be freed during driver's detach.

The driver core clears the driver data to NULL after device_release.
Thus, it is not needed to manually clear the device driver data to NULL.

So remove the unnecessary pci_set_drvdata() and devm_kfree().

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ef817102

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
		struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);

		hnae3_unregister_ae_dev(ae_dev);

		devm_kfree(&pdev->dev, ae_dev);

		pci_set_drvdata(pdev, NULL);
		}

		static struct pci_driver hns3_driver = {