Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c63d1e5c authored by Arnd Bergmann's avatar Arnd Bergmann Committed by David S. Miller
Browse files

net: stmmac: fix unused-variable warning 



When building without CONFIG_OF, we get a harmless build warning:

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_phy_setup':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:973:22: error: unused variable 'node' [-Werror=unused-variable]
  struct device_node *node = priv->plat->phy_node;

Reword it so we always use the local variable, by making it the
fwnode pointer instead of the device_node.

Fixes: 74371272 ("net: stmmac: Convert to phylink and remove phylib logic")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f517f271

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+2 −2
Original line number Diff line number Diff line
@@ -980,14 +980,14 @@ static int stmmac_init_phy(struct net_device *dev) 


static int stmmac_phy_setup(struct stmmac_priv *priv)

{

	struct device_node *node = priv->plat->phylink_node;

	struct fwnode_handle *fwnode = of_fwnode_handle(priv->plat->phylink_node);

	int mode = priv->plat->interface;

	struct phylink *phylink;



	priv->phylink_config.dev = &priv->dev->dev;

	priv->phylink_config.type = PHYLINK_NETDEV;



	phylink = phylink_create(&priv->phylink_config, of_fwnode_handle(node),

	phylink = phylink_create(&priv->phylink_config, fwnode,

				 mode, &stmmac_phylink_mac_ops);

	if (IS_ERR(phylink))

		return PTR_ERR(phylink);