Commit c61c2768 authored Jan 16, 2019 by Mathieu Malaterre Committed by Daniel Borkmann Jan 17, 2019

bpf: Correctly annotate implicit fall through in bpf_base_func_proto

There is a plan to build the kernel with -Wimplicit-fallthrough and
this place in the code produced a warnings (W=1).

To preserve as much of the existing comment only change a ‘:’ into a ‘,’.
This is enough change, to match the regular expression expected by GCC.

This commit removes the following warning:

net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent c8dc7980

net/core/filter.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id)
		case BPF_FUNC_trace_printk:
		if (capable(CAP_SYS_ADMIN))
		return bpf_get_trace_printk_proto();
		/* else: fall through */
		/* else, fall through */
		default:
		return NULL;
		}