Commit c6195a8b authored Mar 01, 2019 by Heiner Kallweit Committed by David S. Miller Mar 03, 2019

net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex



When testing another issue I faced the problem that
mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed
as argument to mv88e6xxx_port_set_duplex(). We should handle this case
gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed()
is doing it.

Fixes: 7f1ae07b ("net: dsa: mv88e6xxx: add port duplex setter")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9b1b4c00

drivers/net/dsa/mv88e6xxx/port.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -190,7 +190,7 @@ int mv88e6xxx_port_set_duplex(struct mv88e6xxx_chip *chip, int port, int dup)
		/* normal duplex detection */
		break;
		default:
		return -EINVAL;
		return -EOPNOTSUPP;
		}

		err = mv88e6xxx_port_write(chip, port, MV88E6XXX_PORT_MAC_CTL, reg);