Commit c5ee0663 authored Jan 02, 2019 by David Ahern Committed by David S. Miller Jan 02, 2019

ipv6: Consider sk_bound_dev_if when binding a socket to an address



IPv6 does not consider if the socket is bound to a device when binding
to an address. The result is that a socket can be bound to eth0 and then
bound to the address of eth1. If the device is a VRF, the result is that
a socket can only be bound to an address in the default VRF.

Resolve by considering the device if sk_bound_dev_if is set.

This problem exists from the beginning of git history.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 73155879

net/ipv6/af_inet6.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -350,6 +350,9 @@ static int __inet6_bind(struct sock sk, struct sockaddr uaddr, int addr_len,
		err = -EINVAL;
		goto out_unlock;
		}
		}

		if (sk->sk_bound_dev_if) {
		dev = dev_get_by_index_rcu(net, sk->sk_bound_dev_if);
		if (!dev) {
		err = -ENODEV;