Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5e12c3a authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

drm/amdgpu: fix off by one in amdgpu_gfx_kiq_acquire() 



[ Upstream commit 1647b54ed55d4d48c7199d439f8834626576cbe9 ]

This post-op should be a pre-op so that we do not pass -1 as the bit
number to test_bit().  The current code will loop downwards from 63 to
-1.  After changing to a pre-op, it loops from 63 to 0.

Fixes: 71c37505 ("drm/amdgpu/gfx: move more common KIQ code to amdgpu_gfx.c")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 00914290

drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

+1 −1
Original line number Diff line number Diff line
@@ -263,7 +263,7 @@ static int amdgpu_gfx_kiq_acquire(struct amdgpu_device *adev, 
		    * adev->gfx.mec.num_pipe_per_mec

		    * adev->gfx.mec.num_queue_per_pipe;



	while (queue_bit-- >= 0) {

	while (--queue_bit >= 0) {

		if (test_bit(queue_bit, adev->gfx.mec.queue_bitmap))

			continue;