Commit c5bc6e52 authored Mar 11, 2019 by Axel Lin Committed by Bartosz Golaszewski Mar 22, 2019

gpio: adnp: Fix testing wrong value in adnp_gpio_direction_input



Current code test wrong value so it does not verify if the written
data is correctly read back. Fix it.
Also make it return -EPERM if read value does not match written bit,
just like it done for adnp_gpio_direction_output().

Fixes: 5e969a40 ("gpio: Add Avionic Design N-bit GPIO expander support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

parent 7ecced09

drivers/gpio/gpio-adnp.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -132,8 +132,10 @@ static int adnp_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
	if (err < 0)		if (err < 0)
	goto out;		goto out;

	if (err & BIT(pos))		if (value & BIT(pos)) {
	err = -EACCES;		err = -EPERM;
			goto out;
			}

	err = 0;		err = 0;