Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c55284e4 authored by Fabio Estevam's avatar Fabio Estevam Committed by David S. Miller
Browse files

fec: Remove irqs first 



During probe the clocks are enabled prior than the acquiring the interrupts.

In the remove function we need to do the opposite: first remove the interrupts
and then disable the clocks.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6a4d607

drivers/net/ethernet/freescale/fec_main.c

+5 −5
Original line number Diff line number Diff line
@@ -2009,6 +2009,11 @@ fec_drv_remove(struct platform_device *pdev) 
	unregister_netdev(ndev);

	fec_enet_mii_remove(fep);

	del_timer_sync(&fep->time_keep);

	for (i = 0; i < FEC_IRQ_NUM; i++) {

		int irq = platform_get_irq(pdev, i);

		if (irq > 0)

			free_irq(irq, ndev);

	}

	if (fep->reg_phy)

		regulator_disable(fep->reg_phy);

	clk_disable_unprepare(fep->clk_ptp);
@@ -2017,11 +2022,6 @@ fec_drv_remove(struct platform_device *pdev) 
	clk_disable_unprepare(fep->clk_enet_out);

	clk_disable_unprepare(fep->clk_ahb);

	clk_disable_unprepare(fep->clk_ipg);

	for (i = 0; i < FEC_IRQ_NUM; i++) {

		int irq = platform_get_irq(pdev, i);

		if (irq > 0)

			free_irq(irq, ndev);

	}

	free_netdev(ndev);



	platform_set_drvdata(pdev, NULL);