Commit c5510b8d authored Dec 06, 2018 by Krzysztof Kozlowski Committed by Linus Walleij Dec 14, 2018

gpiolib: Fix return value of gpio_to_desc() stub if !GPIOLIB



If CONFIG_GPOILIB is not set, the stub of gpio_to_desc() should return
the same type of error as regular version: NULL.  All the callers
compare the return value of gpio_to_desc() against NULL, so returned
ERR_PTR would be treated as non-error case leading to dereferencing of
error value.

Fixes: 79a9becd ("gpiolib: export descriptor-based GPIO interface")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 3a2fa906

include/linux/gpio/consumer.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -505,7 +505,7 @@ static inline int gpiod_set_consumer_name(struct gpio_desc *desc,

		static inline struct gpio_desc *gpio_to_desc(unsigned gpio)
		{
		return ERR_PTR(-EINVAL);
		return NULL;
		}

		static inline int desc_to_gpio(const struct gpio_desc *desc)