Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5493845 authored by Rakesh Pandit's avatar Rakesh Pandit Committed by Jens Axboe
Browse files

lightnvm: pblk: improve error message if down_timeout fails 



The two pr_err messages are useless as they don't differentiate
error code.

Signed-off-by: default avatarRakesh Pandit <rakesh@tuxera.com>
Reviewed-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <m@bjorling.me>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 4e76af53

drivers/lightnvm/pblk-core.c

+2 −10
Original line number Diff line number Diff line
@@ -1691,16 +1691,8 @@ static void __pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, 
#endif



	ret = down_timeout(&rlun->wr_sem, msecs_to_jiffies(30000));

	if (ret) {

		switch (ret) {

		case -ETIME:

			pr_err("pblk: lun semaphore timed out\n");

			break;

		case -EINTR:

			pr_err("pblk: lun semaphore timed out\n");

			break;

		}

	}

	if (ret == -ETIME || ret == -EINTR)

		pr_err("pblk: taking lun semaphore timed out: err %d\n", -ret);

}



void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas)