Commit c53934c6 authored Jan 04, 2016 by Jesse Brandeburg Committed by Jeff Kirsher Feb 17, 2016

i40e: fix: do not sleep in netdev_ops



The driver was being called by VLAN, bonding, teaming operations
that expected to be able to hold locks like rcu_read_lock().

This causes the driver to be held to the requirement to not sleep,
and was found by the kernel debug options for checking sleep
inside critical section, and the locking validator.

Change-ID: Ibc68c835f5ffa8ffe0638ffe910a66fc5649a7f7
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Nelson, Shannon <shannon.nelson@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 38c3cec7

drivers/net/ethernet/intel/i40e/i40e_main.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -1542,7 +1542,11 @@ static int i40e_set_mac(struct net_device netdev, void p)

		ether_addr_copy(netdev->dev_addr, addr->sa_data);

		return i40e_sync_vsi_filters(vsi);
		/* schedule our worker thread which will take care of
		* applying the new filter changes
		*/
		i40e_service_event_schedule(vsi->back);
		return 0;
		}

		/**
		@@ -1766,6 +1770,11 @@ static void i40e_set_rx_mode(struct net_device *netdev)
		vsi->flags \|= I40E_VSI_FLAG_FILTER_CHANGED;
		vsi->back->flags \|= I40E_FLAG_FILTER_SYNC;
		}

		/* schedule our worker thread which will take care of
		* applying the new filter changes
		*/
		i40e_service_event_schedule(vsi->back);
		}

		/**