Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c536a9aa authored by Palmer Dabbelt's avatar Palmer Dabbelt Committed by David S. Miller
Browse files

net: macb: Kconfig: Make MACB depend on COMMON_CLK



commit c218ad55 ("macb: Add support for SiFive FU540-C000") added a
dependency on the common clock framework to the macb driver, but didn't
express that dependency in Kconfig.  As a result macb now fails to
compile on systems without COMMON_CLK, which specifically causes a build
failure on powerpc allyesconfig.

This patch adds the dependency, which results in the macb driver no
longer being selectable on systems without the common clock framework.
All known systems that have this device already support the common clock
framework, so this should not cause trouble for any uses.  Supporting
both the FU540-C000 and systems without COMMON_CLK is quite ugly.

I've build tested this on powerpc allyesconfig and RISC-V defconfig
(which selects MACB), but I have not even booted the resulting kernels.

Fixes: c218ad55 ("macb: Add support for SiFive FU540-C000")
Signed-off-by: default avatarPalmer Dabbelt <palmer@sifive.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 96125bf9
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -21,7 +21,7 @@ if NET_VENDOR_CADENCE

config MACB
	tristate "Cadence MACB/GEM support"
	depends on HAS_DMA
	depends on HAS_DMA && COMMON_CLK
	select PHYLIB
	---help---
	  The Cadence MACB ethernet interface is found on many Atmel AT32 and
@@ -42,7 +42,7 @@ config MACB_USE_HWSTAMP

config MACB_PCI
	tristate "Cadence PCI MACB/GEM support"
	depends on MACB && PCI && COMMON_CLK
	depends on MACB && PCI
	---help---
	  This is PCI wrapper for MACB driver.