Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c52ae3d2 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (gpio_fan) Use error value returned from get_fan_speed_index() 



get_fan_speed_index() returns -EINVAL in case of errors, only to have it
ignored and replaced with -ENODEV. Make it return -ENODEV and use it.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent bb34c0da

drivers/hwmon/gpio-fan.c

+2 −2
Original line number Diff line number Diff line
@@ -169,7 +169,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data) 
	dev_warn(&fan_data->pdev->dev,

		 "missing speed array entry for GPIO value 0x%x\n", ctrl_val);



	return -EINVAL;

	return -ENODEV;

}



static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm)
@@ -384,7 +384,7 @@ static int fan_ctrl_init(struct gpio_fan_data *fan_data, 
	fan_data->pwm_enable = true; /* Enable manual fan speed control. */

	fan_data->speed_index = get_fan_speed_index(fan_data);

	if (fan_data->speed_index < 0)

		return -ENODEV;

		return fan_data->speed_index;



	return 0;

}