Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4fd4379 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: hwdep: prevent a harmless shift wrapping bug 



The "info.index" variable represents a bit in hw->dsp_loaded which is
an unsigned int.  If it's higher than 31 we hit a shift wrapping bug.
This seems harmless, but I wanted to silence the static checker warning.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 2bd6bf03

sound/core/hwdep.c

+2 −0
Original line number Diff line number Diff line
@@ -228,6 +228,8 @@ static int snd_hwdep_dsp_load(struct snd_hwdep *hw, 
	memset(&info, 0, sizeof(info));

	if (copy_from_user(&info, _info, sizeof(info)))

		return -EFAULT;

	if (info.index >= 32)

		return -EINVAL;

	/* check whether the dsp was already loaded */

	if (hw->dsp_loaded & (1 << info.index))

		return -EBUSY;