Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4cf1acd authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: better log intent item refcount checking 



Use ASSERTs on the log intent item refcounts so that we fail noisily if
anyone tries to double-free the item.

Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent 20e8a063

fs/xfs/xfs_bmap_item.c

+1 −0
Original line number Diff line number Diff line
@@ -215,6 +215,7 @@ void 
xfs_bui_release(

	struct xfs_bui_log_item	*buip)

{

	ASSERT(atomic_read(&buip->bui_refcount) > 0);

	if (atomic_dec_and_test(&buip->bui_refcount)) {

		xfs_trans_ail_remove(&buip->bui_item, SHUTDOWN_LOG_IO_ERROR);

		xfs_bui_item_free(buip);

fs/xfs/xfs_extfree_item.c

+1 −0
Original line number Diff line number Diff line
@@ -290,6 +290,7 @@ void 
xfs_efi_release(

	struct xfs_efi_log_item	*efip)

{

	ASSERT(atomic_read(&efip->efi_refcount) > 0);

	if (atomic_dec_and_test(&efip->efi_refcount)) {

		xfs_trans_ail_remove(&efip->efi_item, SHUTDOWN_LOG_IO_ERROR);

		xfs_efi_item_free(efip);

fs/xfs/xfs_refcount_item.c

+1 −0
Original line number Diff line number Diff line
@@ -221,6 +221,7 @@ void 
xfs_cui_release(

	struct xfs_cui_log_item	*cuip)

{

	ASSERT(atomic_read(&cuip->cui_refcount) > 0);

	if (atomic_dec_and_test(&cuip->cui_refcount)) {

		xfs_trans_ail_remove(&cuip->cui_item, SHUTDOWN_LOG_IO_ERROR);

		xfs_cui_item_free(cuip);

fs/xfs/xfs_rmap_item.c

+1 −0
Original line number Diff line number Diff line
@@ -243,6 +243,7 @@ void 
xfs_rui_release(

	struct xfs_rui_log_item	*ruip)

{

	ASSERT(atomic_read(&ruip->rui_refcount) > 0);

	if (atomic_dec_and_test(&ruip->rui_refcount)) {

		xfs_trans_ail_remove(&ruip->rui_item, SHUTDOWN_LOG_IO_ERROR);

		xfs_rui_item_free(ruip);